Make scope optional #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraBle
force-pushed
the
FB/node16-upstream
branch
2 times, most recently
from
bf26ccb to
dddc726
Compare
FraBle
changed the title
FraBle
force-pushed
the
FB/node16-upstream
branch
from
dddc726 to
18f1d7e
Compare
|
Hey FraBle, Sorry for the late response it was a long weekend :). I'll take a look a little later today. |
|
@daryl-miller oh, for sure, no worries 🙌 |
daryl-miller
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the downgrade from Node 18 to 16 already made it in. Apologies, I did not anticipate actions/runner-images#7002 to get in our way since https://github.com/actions/setup-node already supports Node 18.
This PR is a quick follow. It makes the
scopeoptional (and refreshes the readme a little). Why the change? It allows using AWS CodeArtifact as a mirror for npm ("external connection").