Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If NPM supports it, set config scope to project-level instead of system-level #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akremer
Copy link

@akremer akremer commented Apr 28, 2023

This package currently sets the registry at system level, which could cause issues if a runner is tasked with some builds that require a private repository and some builds that require the public repository.

Since V8, npm has supported the -L flag, which enables us to specify that the registry setting should be at the project level, not system level. This enhancement sets this behavior by default (when npm is 8 or greater).

The effects are that a local .npmrc is created in the build directory when the npm config command is set.

@daryl-miller
Copy link
Collaborator

Sorry for missing this, I'll take a look this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants