Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#250 wait style #255

Merged
merged 6 commits into from
Mar 13, 2019
Merged

Feature/#250 wait style #255

merged 6 commits into from
Mar 13, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Mar 13, 2019

  • Added computed element.style field.
  • Added helper functions ATTR_GET, ATTR_SET, ATTR_REMOVE, STYLE_GET, STYLE_SET, STYLE_REMOVE.

@ziflex ziflex requested a review from 3timeslazy March 13, 2019 15:32
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #255 into master will decrease coverage by 3%.
The diff coverage is 33.7%.

@@           Coverage Diff           @@
##           master    #255    +/-   ##
=======================================
- Coverage      60%   57.1%    -3%     
=======================================
  Files         179     189    +10     
  Lines        5296    5671   +375     
=======================================
+ Hits         3180    3237    +57     
- Misses       1766    2084   +318     
  Partials      350     350

Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I have not checked all 1200 lines. Approve.

@ziflex ziflex merged commit 376ad77 into master Mar 13, 2019
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added support for parsed styles

* Added stdlib function.

* Added e2e tests

* Added e2e tests for STYLE_* functions
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added support for parsed styles

* Added stdlib function.

* Added e2e tests

* Added e2e tests for STYLE_* functions
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added support for parsed styles

* Added stdlib function.

* Added e2e tests

* Added e2e tests for STYLE_* functions
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added support for parsed styles

* Added stdlib function.

* Added e2e tests

* Added e2e tests for STYLE_* functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants