Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check whether an element is in the viewport before scrolling #342

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Jul 26, 2019

In v0.8, we have introduced a new behavior that emulates users by scrolling viewport into an element before clicking or typing. Unfortunately, we didn't any checks whether an element is already in the viewport which led to some and unnatural behavior .

@ziflex ziflex added type/bug Something isn't working area/drivers/cdp Cdp driver area/drivers HTML drivers labels Jul 26, 2019
@ziflex ziflex requested a review from 3timeslazy July 26, 2019 18:19
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #342 into master will decrease coverage by <.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #342     +/-   ##
========================================
- Coverage    39.9%   39.9%   -<.1%     
========================================
  Files         218     218             
  Lines        8608    8608             
========================================
- Hits         3436    3435      -1     
  Misses       4819    4819             
- Partials      353     354      +1

@ziflex ziflex merged commit 843bc2a into master Jul 26, 2019
@ziflex ziflex deleted the bugfix/scrolling branch July 27, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/drivers/cdp Cdp driver area/drivers HTML drivers type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants