Send notification when video play fails #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ISA doesn't support Representations with multiple BaseURLs - Dont block adaptive formats for clients that may need PO tokens - Some urls for adaptive formats may be blocked even if client does need a PO token - As not all urls may be blocked, use HTTPServer to try them all as a proxy to ISA
MoojMidge
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Would suggest just adding the notification once in yt_play.process, rather than in multiple places in yt_play._play_stream:
media_item = _play_stream(provider, context)
if media_item:
if position and items:
ui.set_property(PLAYLIST_PATH,
items[position - 1]['file'])
ui.set_property(PLAYLIST_POSITION, str(position))
else:
ui.clear_property(BUSY_FLAG)
context.send_notification(PLAYBACK_FAILED, {'video_id': video_id})
But looking at it from a higher level, if the intent is to close a dialog and re-open it once playback has completed, wouldn't a better way of doing this be to only close the dialog if the PLAYBACK_STARTED notification is received?
| @@ -63,6 +63,7 @@ | |||
| PLAYBACK_STOPPED = 'playback_stopped' | |||
| REFRESH_CONTAINER = 'refresh_container' | |||
| RELOAD_ACCESS_MANAGER = 'reload_access_manager' | |||
| PLAYBACK_FAILED = 'playback_failed' | |||
There was a problem hiding this comment.
Can you keep this group of events in alphabetical order? And the __all__ tuple too.
MoojMidge
force-pushed
the
master
branch
5 times, most recently
from
647f603 to
6092bce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to provide mechanism to alert addons via xbmc.Monitor.onNotification() when addon invokes plugin via PlayMedia() and Youtube is unable to play the video (ex. no streams found)
Add a new notification event "PLAYBACK_FAILED"
Add new calls to method send_notification in yt_play.py when plugin attempts to start play of video but youtube is unable to handle for any reason.