Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case when registry does not exist #65

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

alkuzad
Copy link
Contributor

@alkuzad alkuzad commented Feb 25, 2023

WinReg path is added after first installation of custom Docset and closing Zeal. Use default for this case

Describe Your Changes:

If there is no key, use default

Linked Issues:

Change Type

Category

  • This is a Minor Change which does not fit any other category.
  • This is a Bugfix
  • This is a Feature Addition
  • This is a CI Change
  • This is a Documentation-Only Change (do not check any of the above boxes if this box is checked)

Breaking/Non Breaking

  • This is a Breaking Change
  • This is a Non-Breaking Change

Reasoning

Seems that the value in Registry is created only after first custom doc installation and closing program. In this case we have to use assumed default. User still can change location in UI and this won't impact zeal-cli config, but this is on the user to move data and change config.

Copyright Assignment

  • [x ] I have filled out the copyright assignment at https://copyright.morpheus636.com for this pull request.
  • I am Morpheus636 so I do not need to fill out the copyright assignment.

Why do I require a copyright assignment?

Click to expand I require a copyright assignment for changes to my projects for the same reason as the Free Software Foundation, and they do a much better job of explaining it in their post at https://www.gnu.org/licenses/why-assign.en.html than I could ever do.

Please email any questions about the copyright assignment to [email protected]

WinReg path is added after first installation of custom Docset and closing Zeal. Use default for this case
Copy link
Owner

@Morpheus636 Morpheus636 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Morpheus636 Morpheus636 merged commit 748d8a9 into Morpheus636:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants