Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error page on locked missions/tracks #29

Open
privat opened this issue Aug 16, 2016 · 6 comments
Open

error page on locked missions/tracks #29

privat opened this issue Aug 16, 2016 · 6 comments

Comments

@privat
Copy link
Collaborator

privat commented Aug 16, 2016

If the track is open, locked mission should says that the mission is locked.
If the track is hidden/inaccessible (of the player not authenticated), the track page and its missions should 404

Constraints:

  • do the locking server-side
  • bypass the lock in debug mode (just add whatever refinement in src/debug.nit and/or in the config file)
@Morriar Morriar added the bug label Aug 24, 2016
@Morriar
Copy link
Owner

Morriar commented Aug 24, 2016

I think there is another issue in here: enable/disable tracks.

Please open another issue with the label enhancement for that.

Working on the locked status though.

@privat
Copy link
Collaborator Author

privat commented Aug 25, 2016

is this closed by #46?

@privat privat reopened this Aug 31, 2016
@privat
Copy link
Collaborator Author

privat commented Sep 1, 2016

Reopened because #46 was client-side only, and thus partially reverted in #77

@Morriar Morriar modified the milestone: Short term Sep 1, 2016
@privat privat assigned Morriar and ppepos and unassigned Morriar and ppepos Sep 8, 2016
@Morriar
Copy link
Owner

Morriar commented Sep 12, 2016

I don't understand. On one hand you want to be able to see locked mission and you don't want a lock client-side.

What is the true concern behind this issue?

@privat
Copy link
Collaborator Author

privat commented Sep 13, 2016

What I want now?

  • do not lock anything effectively

What that means?

  • display "lock" if you want to test that the lock message is OK
  • still allow the tester to see the mission and to play it

Rationale

  • the tester does not want to spend numerous clics or to finish the previous missions in order to test something on a specific mission.
  • moreover, if the lock mechanism, is buggy. then the tester can still test other parts of the system.

What I want later?

  • enforce lock policy for the production server
  • but do the locking server-side. There is no point all all to simulate it client-side
  • still allow to bypass locks in the devel mode to test things

How to implement that later?

  • I do not think that we need to think too much about that right now
  • If we want a full lock (without any information), the API could just send a 403 HTTP response for locked ressources
  • If we want a full lock + debug mode. maybe you can attach a god flag the the player in order to let the API bypass the lock check for those selected people

@Morriar Morriar mentioned this issue Sep 13, 2016
@Morriar
Copy link
Owner

Morriar commented Sep 13, 2016

To me, what you need is a debug/god mode.

See #111

privat pushed a commit that referenced this issue Sep 13, 2016
Simplify and fix (hopefully) some issues with stars, internal errors and statuses. close #29

Pull-Request: #112
privat pushed a commit that referenced this issue Sep 13, 2016
Simplify and fix (hopefully) some issues with stars, internal errors and statuses. close #29

Pull-Request: #112
Reviewed-by: Alexandre Terrasa <[email protected]>
@Morriar Morriar modified the milestone: Short term (Prod labos) Sep 26, 2016
@privat privat mentioned this issue Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants