-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome logs and other LevelDB-related cleaning #320
Comments
Thanks for your clarification. I don't use Chrome, therefore I can't really comment this. All I can say is that the entry is very old and that we never have got issue reports since we have added the ExcludeKeys. @MoscaDotTo What's your opinion? Should we merge the entries [Logs *] and [Logs Old *], change the pattern to |LOG;LOG.old|RECURSE and remove the ExcludeKeys? But I think not everybody will be happy with these changes. Or will you discuss it in the community forum first? |
Same about |
I opened a new pull request. @MoscaDotTo I will wait for your opinion/decision before I will merge the pull request. |
I think we should avoid unexpectedly breaking configurations as best we can. Especially for things like Browser Extensions where for most users, tracking down why they lost their settings is probably an impossibility. Perhaps a more dangerous entry in winapp3 for people who supremely don't want the log files, or otherwise don't have any extensions whose configurations would be damaged by this entry? |
Just to clarify: it's not only about extensions. It's used for various things across the user profile. |
Thanks for your reply. Good, then I will merge the pull request tomorrow. Yes, we could add the dangerous version of the entry [Logs *] to Winapp3.ini. But I think that the original entry was created without the necessary knowledge (that the .log files are not usual logs, but important database files). Thanks to EvgenKo423 we are now smarter. |
Agreed. After reviewing the LevelDB documentation this seems to be the case. |
Changes/fixes by request: #320. Fixed invalid LevelDB cleaning: - Merged and revised entries [Logs *] and [Logs Old *], because they deleted important database files. - Removed entry [Web Applications *], because it deleted useful database files. Also covered by entry [HTML5 Storage *] already. - Revised entry [Internet Cache *], because it deleted important database files. - Renamed entry [LevelDB Storage *] to [Data Reduction Proxy *].
The pull request has been merged. I hope that the Chrome entries are ok now. |
Chrome
[Logs *]
cleaning entry is invalid and will probably cause a lot of damage (even if you won't notice it in some way)!Folders like
User Data\Default\Extension State
is aLevelDB
database and.log
files in there are not a usual logs. They are buffers of an actual data stored in those databases and you shouldn't mess with them as it will most likely corrupt the database!You should delete the whole contents of such folders if you wanna clean some database. Otherwise only
LOG
andLOG.old
files (the actual logs) can be deleted. There will be no need in exclude entries if you only clean the actual logs.See here for more info.
EDIT: There are no any other
.log
files in a Chrome profile.The text was updated successfully, but these errors were encountered: