Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome logs and other LevelDB-related cleaning #320

Closed
EvgenKo423 opened this issue Nov 10, 2018 · 8 comments
Closed

Chrome logs and other LevelDB-related cleaning #320

EvgenKo423 opened this issue Nov 10, 2018 · 8 comments
Labels
Fixed Indicates that a bug has been resolved winapp2 For issues related to winapp2.ini

Comments

@EvgenKo423
Copy link

EvgenKo423 commented Nov 10, 2018

Chrome [Logs *] cleaning entry is invalid and will probably cause a lot of damage (even if you won't notice it in some way)!

Folders like User Data\Default\Extension State is a LevelDB database and .log files in there are not a usual logs. They are buffers of an actual data stored in those databases and you shouldn't mess with them as it will most likely corrupt the database!
You should delete the whole contents of such folders if you wanna clean some database. Otherwise only LOG and LOG.old files (the actual logs) can be deleted. There will be no need in exclude entries if you only clean the actual logs.

See here for more info.

EDIT: There are no any other .log files in a Chrome profile.

@APMichael
Copy link
Collaborator

APMichael commented Nov 10, 2018

Thanks for your clarification.

I don't use Chrome, therefore I can't really comment this. All I can say is that the entry is very old and that we never have got issue reports since we have added the ExcludeKeys.

@MoscaDotTo What's your opinion? Should we merge the entries [Logs *] and [Logs Old *], change the pattern to |LOG;LOG.old|RECURSE and remove the ExcludeKeys? But I think not everybody will be happy with these changes. Or will you discuss it in the community forum first?

@EvgenKo423
Copy link
Author

Same about [Web Applications *] entry: it deletes part of useful files.
BTW, it's not needed as it's a part of [HTML5 Storage *] entry.

APMichael added a commit that referenced this issue Nov 12, 2018
Changes/fixes by request: #320.
- Merged and revised entries [Logs *] and [Logs Old *], because they deleted important database files.
- Removed entry [Web Applications *], because it deleted important database files. Also covered by entry [HTML5 Storage *] already.
@APMichael APMichael mentioned this issue Nov 12, 2018
@APMichael
Copy link
Collaborator

I opened a new pull request.

@MoscaDotTo I will wait for your opinion/decision before I will merge the pull request.

@MoscaDotTo
Copy link
Owner

I think we should avoid unexpectedly breaking configurations as best we can. Especially for things like Browser Extensions where for most users, tracking down why they lost their settings is probably an impossibility.

Perhaps a more dangerous entry in winapp3 for people who supremely don't want the log files, or otherwise don't have any extensions whose configurations would be damaged by this entry?

@EvgenKo423
Copy link
Author

Just to clarify: it's not only about extensions. It's used for various things across the user profile.

@APMichael
Copy link
Collaborator

APMichael commented Nov 13, 2018

Thanks for your reply. Good, then I will merge the pull request tomorrow.

Yes, we could add the dangerous version of the entry [Logs *] to Winapp3.ini. But I think that the original entry was created without the necessary knowledge (that the .log files are not usual logs, but important database files). Thanks to EvgenKo423 we are now smarter.

@MoscaDotTo
Copy link
Owner

Agreed. After reviewing the LevelDB documentation this seems to be the case.

APMichael added a commit that referenced this issue Nov 14, 2018
Changes/fixes by request: #320.

Fixed invalid LevelDB cleaning:
- Merged and revised entries [Logs *] and [Logs Old *], because they deleted important database files.
- Removed entry [Web Applications *], because it deleted useful database files. Also covered by entry [HTML5 Storage *] already.
- Revised entry [Internet Cache *], because it deleted important database files.
- Renamed entry [LevelDB Storage *] to [Data Reduction Proxy *].
@APMichael
Copy link
Collaborator

The pull request has been merged. I hope that the Chrome entries are ok now.

@APMichael APMichael added the Fixed Indicates that a bug has been resolved label Nov 17, 2018
@APMichael APMichael added the winapp2 For issues related to winapp2.ini label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Indicates that a bug has been resolved winapp2 For issues related to winapp2.ini
Projects
None yet
Development

No branches or pull requests

3 participants