Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unordered Printing #10

Open
ptth222 opened this issue May 31, 2023 · 0 comments
Open

Unordered Printing #10

ptth222 opened this issue May 31, 2023 · 0 comments

Comments

@ptth222
Copy link
Collaborator

ptth222 commented May 31, 2023

When printing the mwTab file from the internal dictionary the package simply prints in the order of dictionary insertion rather than the order specified by the mwTab format. The function is on line 239 of mwtab.py.

Either this function should change to always print in the correct order, or the validation should change to check for correct order of the dictionary, possibly both. Currently, the package will validate an incorrect order and you can print out an invalid file. Always printing in the correct order is made a little complicated by the fact that there are 3 possible configurations (MS, NMR, NMR binned).

Note that not just the order of the blocks is important, but also the order of the sections inside the blocks. For example, units should be before the data in the MS block.

ptth222 added a commit that referenced this issue Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant