Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing problem between returned stop-fn and with-...-queue fixtures #27

Closed
ghost opened this issue Aug 11, 2020 · 0 comments · Fixed by #87
Closed

Timing problem between returned stop-fn and with-...-queue fixtures #27

ghost opened this issue Aug 11, 2020 · 0 comments · Fixed by #87
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Aug 11, 2020

There is currently a sleep workaround in place inside the test-fixtures.clj

Without this pause, its possible that the queue get deleted by the fixture while a listener thread is still trying to read it which will cause an exception. That doesn't influence the test result, but still shouldn't happen. In a real-world situation it is highly unlikely that someone suddenly kills the used queue and if that happens the exception is correct.

For the test cases it would still be nice to have a cleaner way here.

Maybe we can make use of wait-for here, too? See #44

@ghost ghost added the enhancement New feature or request label Aug 11, 2020
@ghost ghost added this to the v0.2 milestone Aug 26, 2020
@Quantisan Quantisan modified the milestones: v0.2, v0.3 Sep 5, 2020
@Quantisan Quantisan linked a pull request Sep 17, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant