Fixed Timing problem between returned stop-fn and with-...-queue fixtures #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Even this apparently isn't necessary anymore. The issue is quite old and the tests/code seems to have changed/improved enough that the issue's timing problem is not remaining anymore. Please refer to: #87 |
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #27.
Changes:
with-...-queuefixtures clear thetest-queue-urlbefore deleting the queuetest-queue-urlto be defined before inserting the message into the receiver channel (which then later could get autoremoved when the queue is already gone)