Bug fix undefined error, if destory is called before timers have fired

[raido]

I have an application where user can enable/disable keyboard via UI button. If button is clicked multiple times in a row, then undefined errors are thrown, because timers are not torn down when calling destroy(). I propose this quick fix by adding extra if guards in timer handlers.

[raido]

Proper fix would be clearing all timeouts in destroy(), i may look into this, if i have more time. This solution is a quick fix.

These timers also make unit testing difficult where it is included, because unit tests call destroy and timers fire after it.

[Mottie]

Hi @raido!

Hmm, how are you destroying/initializing the keyboard? I used this code and could not duplicate the issue (demo):

$('button').click(function () {
    var kb = $('#keyboard').getkeyboard();
    if (kb) {
        kb.destroy();
        $(this).text('Restore');
    } else {
        $(this).text('Destroy');
        $('#keyboard').keyboard();
    }
});

And maybe it would just be better to add this code in the destroy method:

clearTimeout(base.timer);

[raido]

Hi @Mottie

clearTimeout(base.timer) does not work in my case, there are other timeouts that fire nevertheless.

Key thing that makes it break, is to call focus on the input right after the initialization, see demo - http://jsfiddle.net/egb3a1sk/227/

[Mottie]

ok thanks!

[raido]

I'll be waiting for the patch release :)

[Mottie]

You didn't have to wait long 😉