Syriac support #723
Merged
Syriac support #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sixtyfive! Yes, I would be grateful for the help! Also, the alt keyset that is full of |
debating them together until they were both happy.
|
Hi @Mottie! There are two variants of this. The one in my PR is based on the corresponding Arabic letter's locations on the Arabic keyboard. The other one is based on phonetic relationships among the Syriac letters. According to my (academic) sources (otherwise called colleagues) both are in active use within the community, so it would be good to have both. |
|
Is this PR ready to be merged? |
|
I understood your first comment to mean that it is indeed possible to have two different layouts for one language? So then - no, not yet! |
|
PR is now ready to be merged. |
Mottie
reviewed
Feb 10, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I make this pretty, would you guys be interested in merging the PR?