Duplicate AJAX requests using the filter formatter widget with server-side options

[sbine]

I'm using tablesorter with server-side pagination, sorting, and filtering. It seems that setting initial filter values using the filter formatter widget causes two (sometimes three) identical AJAX requests to be fired when the table is first loaded. Subsequent filters behave as expected.

For example:

function($cell, indx) {
    return $.tablesorter.filterFormatter.html5Range( $cell, indx, {
        value: 600,
        min: 0,
        max: 800,
        delayed: true,
        valueToHeader: false,
        exactMatch: false
    });
}

sends the request twice

?page=0&size=25&filter[2]=600&sort[1]=1
?page=0&size=25&filter[2]=600&sort[1]=1

Since this only occurs when the table is first loaded I suspect it may be related to #343. Any help would be appreciated, and thank you for your work on this amazing plugin.

[Mottie]

Hi @sbine!

Just letting you know I'm back and I'll be looking into this issue. Thanks for reporting it!

[sbine]

Thank you @Mottie! I spent several hours today attempting to debug this issue and came up with a temporary fix.

Starting on line 279 of jquery.tablesorter.pager.js, changing:

$t.trigger('update');
c.totalPages = Math.ceil( c.totalRows / c.size );
updatePageDisplay(table, c);
fixHeight(table, c);
if (c.initialized) { $t.trigger('pagerChange', c); }

to

c.totalPages = Math.ceil( c.totalRows / c.size );
updatePageDisplay(table, c);
fixHeight(table, c);
if (c.initialized) {
    $t.trigger('pagerChange', c);
}
else {
    $t.trigger('update');
}

gets rid of one of the duplicate requests.
Due to my extremely limited knowledge of the plugin's codebase, I'm not sure if this is the correct solution, but I hope it helps you get to the root of the problem.

[Mottie]

Hmm, if you're not triggering an update, then the plugin doesn't update the cache... and umm, I guess since you're using ajax the server does all the sorting/filtering, you don't need to cache the data anyway. So, I guess just completely remove that $t.trigger('update');.... can you think of a case that would need it, within an ajax call? Hmmm.

[sbine]

Right, caching becomes unnecessary in my case. Perhaps caching-specific code in each widget could be skipped over when its respective server-side option is enabled?

[Mottie]

Ok, I'm hoping this bug is all squashing and isn't sticking to my shoe... I don't wanna look because it'll be icky. LOL

[sbine]

Hi again Mottie! As much as I hate bugs... it seems removing the update trigger does actually break table functionality. I upgraded to 2.11.0 this morning and had to make these changes to get my tables to function:

jquery.tablesorter.pager.js line 157, add back:

else {
    c.$table.trigger('update');
}

jquery.tablesorter.js line 346, add the following:

$(table).trigger("updateComplete", table);

updateComplete was not being triggered on tables without the filter formatter widget, but with all server-side options set. My tables that do use the filter formatter widget were working without this change.

Sorry for the trouble, and thank you for your help :)

[Mottie]

Hi @sbine!

Thanks for sharing how to fix it. I'll get that updated in a few minutes.

Edit: Umm, I guess the line numbers don't match the version I have... basically the same place right?

[sbine]

Yes, the update trigger goes where it was before. The second change was at the end of the appendToTable function, after $(table).trigger("sortEnd", table);.