Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle to prevent guava conflicts #34

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

iojw
Copy link
Member

@iojw iojw commented Jan 22, 2017

com.google.apis:google-api-services-drive:v2-rev193-1.20.0 depends on guava-jdk5, which is no longer maintained as well as causes conflicts with vanilla guava when run with Terasology due to there being multiple instances of guava on the classpath. This is also mentioned in MovingBlocks/Terasology#2584.

This PR fixes the issue by excluding guava-jdk5 and instead including vanilla guava in the cr-core build.gradle.

@msteiger
Copy link
Member

Afaics, it is still used to support Java 5 applications. According to the issue reported here:

googleapis/google-api-java-client#903 (comment)

Overriding with guava 18 or 19 should be safe.

@msteiger msteiger merged commit a12185a into MovingBlocks:develop Jan 23, 2017
@Cervator
Copy link
Member

Added a small comment in a separate commit then released :-)

https://github.com/MovingBlocks/CrashReporter/releases/tag/v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants