Various isses with movement inputs persisting through the chatbox

[Vizaxo]

There are various issues concerning movement inputs persisting through the chatbox:

1. If you hold down a movement key, then press 't' to open the chatbox, the movement will persist until you let go of it (expected: movement will stop moving the player upon opening the chatbox).
2. If you hold down two movement keys in different planes (i.e. left or right, and forward or backward), they will both persist when the chatbox is opened. Letting go of one of them will stop movement in that direction, and then letting go of the other will stop movement completely.
3. Holding down up and down at the same time will not allow you to open the chatbox.
4. Holding down left and right at the same time will work the same as (2), but with you standing still at the start, then starting to move when you let go of one direction.
5. Pressing 'r' to automove will keep you moving after opening the chatbox, but will be turned off when the key bound to forward is pressed (expected: either automove will stop upon opening the chatbox, or it will continue until you exit the chatbox and stop it manually).
6. Holding shift and opening the chatbox (whether moving at the time or not), then releasing shift and closing the chatbox will make your character move slowly (as if shift was held) until you press and release shift again.

Log details and game version

Game version: tested both on the latest source tree (commit 7e3ba2c), and the Omega 691 binaries from http://forum.terasology.org/threads/play-test-session-sunday-march-19th-1-pm-us-eastern-time.1814/.

Computer details

GNU/Linux Ubuntu 16.10

[Cervator]

One additional (if barely different) case: immediately after opening the chat box with t (or the console) even after having let go of said button the next button press like one of wasd will trigger movement. After letting go once everything is fine.

Pinging @ThompsonTyler due to extensive research on potentially adding modifier key support requested in #2551, also a includes a great summary of involved classes - #2551 (comment) - curious if it rings a bell or additional feedback/ideas may be available :-)

[ThompsonTyler]

Will take a look, see if I can see anything. (Sorry bout the absence lately, messed up my hand and gotta do everything 1 handed atm)

Was able to replicate all problems other than Cervators(Not sure if I am understand it wrong, but if I open chat box and press was or d I don't see any movement)

Also problem 3 I wasn't able to replicate (holding forward/back preventing chat from opening)

[Vizaxo]

Ah, yes, after some more testing I think issue 3 is due to my keyboard not sending all of the signals at once (it gives the same results in the terminal). Nothing wrong with the game there :P

I have been able to replicate Cervator's, but it only happens when the chat window starts out empty. If there's already writing in it, the command won't make you move. Additionally, if you empty the window without leaving it (either backspacing all the way, or hitting enter in the command window), the first press after that will make you move too. Other buttons, such as spacebar to jump, don't seem to be able to be pressed in this way.

[ThompsonTyler]

Got a fix going for 1, 2, 4, and 6. (Could fix 5, but want to ask around in irc about something that seems weird to me, but would fix problem) Will wait on talking before putting through a PR.

Note, these fixes only apple to chat, console grabs events with a higher priority and does something odd with the opening event that kind of confuses me, will need to talk to someone about that first.

[oniatus]

Merged #2839 so the first letter does no longer move the player.

I could still walk with the console open if i hold 'ctrl' while pressing a movement key. Not sure if this is the intended behavior though.