Update world gen. configuration with Component clones #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
Tested around some, making config changes with heightmap and previewing a bunch. Looks fine. Does that cover the changes? Pinging @flo if interested in commenting on the fun with contexts |
|
This will propably collide with the changes @immortius made about the engine life cycle. See his last comment on #1770 |
|
Probably not worth worrying about my branch though, who knows when it will be ready. |
|
Went ahead and merged it then, at least it isn't a huge number of changes to deal with :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the current property binding scheme for world gen. configuration. Previously, fields were modified directly through PropertyProvider's reflection system. This has the drawback that world gens are not notified (or only afterwards) that a parameter has changed.
This PR uses copies of configuration components and calls worldConfig.setProperty() as usual. This allows the world gen. to update accordingly (reload a height map, clear caches) or even decline the new parameter set.
I had to change
handleSwitchToPreviewEnvironment.handleSwitchToPreviewEnvironmentso it would update theComponentLibrarywith the new module environment. It also uses the sub-context now. Unfortunately, this update cannot be undone atm. Since this is using the sub-context only, it should be ok though.To test this try the HeightMap world gen. or PolyWorld. Both should work nicely now even when the height map / graph density is modified.