-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[telemetry] game play metric #3016
Conversation
Hooray Jenkins reported success with all tests good! |
Hooray Jenkins reported success with all tests good! |
Hooray Jenkins reported success with all tests good! |
Hooray Jenkins reported success with all tests good! |
Update
|
Hooray Jenkins reported success with all tests good! |
Tested it out :-) Saw the gameplay metrics update live in-game, cool! And then at the end of the session that payload was prepared and sent to the server. Neato. Although the logging is a little cryptic and seemed to repeat itself, is that an issue?
On the utility server there is a bunch of odd looking fields without data, and also one surprise: the user's IP address gets sent - maybe we should avoid that one? I'm thinking It'll be fun getting started on actual smart searches and graphs to get sensible stuff out of it all. For now everything seems to be fine so merging! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran over the changes real quick, few minor comments but nothing that needs to be changed right away :-)
instigator.addOrSaveComponent(gamePlayStatsComponent); | ||
} | ||
} else if (entityRef.hasComponent(CharacterComponent.class)) { | ||
String monsterName = entityRef.getParentPrefab().getName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for later: maybe this shouldn't be "monster" specific since it would cover all kinds of things. A deer isn't really a monster. Would killing another player count?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Cervator , sorry about the delay :) not tested but I think that killing another player count. Do you think "creature" would be better as a name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very belated reply from me: yes IMHO "creature" is better :-)
@TelemetryField | ||
private Map monsterKilledMap; | ||
|
||
public MonsterKilledMetric() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an explicit empty public constructor really needed? Thought that was present by default. Unless marking the class final
does something.
@@ -260,7 +260,13 @@ | |||
"telemetry-launch-popup-text": "Telemetry system will send metrics and errors to the server. We do our best to avoid sending anything identifiable from your PC, e.g. telemetry includes your OS name, Java version but it doesn't include the MAC address, the home path, etc. You can review in Metric Menu and let us know if we missed something. Telemetry is super useful to an all volunteer project like ours and we'd really appreciate it!", | |||
"telemetry-launch-popup-title": "Telemetry In Terasology", | |||
"telemetry-menu": "Metrics Menu", | |||
"telemetry-system-context": "System context", | |||
"telemetry-description": "This screen shows the metrics and their values that will be sent to the server. You can enable/disable it here. Telemetry is super useful to an all volunteer project like ours and we'd really appreciate it!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to adding new translated English entries in menu_en.lang
please also add placeholder entries menu.lang
so Weblate and such can figure out there are new keys :-)
Contains
Game play metric including:
How to test
Metrics Menu
Send metrics to server
, the metrics will be sent to http://utility.terasology.org/. You can see on port 5601 http://utility.terasology.org:5601/@rzats @oniatus @skaldarnar @msteiger @Cervator @qwc thanks for review :-)