Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New create game flow, final touches #3388

Merged
merged 9 commits into from
Jun 15, 2018
Merged

New create game flow, final touches #3388

merged 9 commits into from
Jun 15, 2018

Conversation

TheFlash98
Copy link
Member

Contains

Disabled the time progression slider and world shape drop down. Changed the UI of the WorldSetupScreen and removed the Message Popup which appeared by clicking "Re-Roll".

@GooeyHub
Copy link
Member

GooeyHub commented Jun 9, 2018

Hooray Jenkins reported success with all tests good!

@GooeyHub
Copy link
Member

GooeyHub commented Jun 9, 2018

Hooray Jenkins reported success with all tests good!

@TheFlash98 TheFlash98 changed the title New create game flow, final touched New create game flow, final touches Jun 9, 2018
@Cervator
Copy link
Member

Good progress, thank you :-)

Noticed one issue - the "Accept" and "Cancel" buttons on world config do the same thing, both accept any changes made. Is that something we can easily address, or does it come down to how the UI elements are mapped to their backing data? If they save the moment you change a UI element then there isn't much to do and we could probably just outright remove the "Cancel" button. Let me know what you think.

On other issue I'm still not sure how to deal with is not letting the zoom regenerate trigger until the user lets go of the slider. That might be another case of the UI system being tricky?

Maybe @rzats could provide some insight sometime.

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

nihal111
nihal111 approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@nihal111 nihal111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Try to make the UISlider listen to changes only and not use the set binding. The behaviour is very glitchy atm.

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@nihal111
Copy link
Member

LGTM, merging!

@nihal111 nihal111 merged commit 6b677f6 into MovingBlocks:create-game-v2 Jun 15, 2018
@nihal111 nihal111 mentioned this pull request Jun 17, 2018
Closed
@TheFlash98
Copy link
Member Author

theflash98 & multi-world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihal111 nihal111 nihal111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheFlash98 @GooeyHub @Cervator @nihal111