Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: address PMD GuardLogStatement warnings #5209

Merged
merged 30 commits into from
May 17, 2024
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3b23f5d
qa engine, audio, fluent logger.
soloturn Dec 2, 2023
e9c4f14
qa engine, config, fluent logger.
soloturn Dec 2, 2023
496fcca
qa engine, core, fluent logger.
soloturn Dec 2, 2023
6611111
qa engine, entitySystem, fluent logger.
soloturn Dec 2, 2023
23e58cc
qa engine, game, fluent logger.
soloturn Dec 2, 2023
c182e76
qa engine, identity, fluent logger.
soloturn Dec 2, 2023
cf84823
qa engine, input, fluent logger.
soloturn Dec 2, 2023
f0b2bab
qa engine, logic, fluent logger.
soloturn Dec 2, 2023
d5a0dba
qa engine, network, fluent logger.
soloturn Dec 2, 2023
3f69b34
qa engine, particles, fluent logger.
soloturn Dec 2, 2023
c1230d3
qa engine, persistence, fluent logger.
soloturn Dec 2, 2023
3cd9936
qa engine, physics, fluent logger.
soloturn Dec 2, 2023
c3c6c4b
qa engine, recording, fluent logger.
soloturn Dec 2, 2023
87fae23
qa engine, registry, fluent logger.
soloturn Dec 2, 2023
f4487b8
qa engine, rendering, fluent logger.
soloturn Dec 2, 2023
1a7fe0b
qa engine, utilities, fluent logger.
soloturn Dec 2, 2023
2a293e5
qa engine, world, fluent logger.
soloturn Dec 2, 2023
be19e62
review feedback pr
soloturn Feb 12, 2024
e9fad3d
feedback fluent-logger pr. except to make log line shorter.
soloturn Feb 12, 2024
cf50c8e
Update engine/src/main/java/org/terasology/engine/rendering/opengl/Op…
soloturn Apr 7, 2024
f8b792c
line length warning removed
soloturn May 13, 2024
12ae29a
refactor: use less verbose varient of fluent API
jdrueckert May 17, 2024
3705eff
fix: //NOPMD doesn't work if log spans multiple lines
jdrueckert May 17, 2024
c48561f
refactor: introduce and reference local variables
jdrueckert May 17, 2024
56f9ed8
refactor: suppress guardlogstatement warnings for methods intended fo…
jdrueckert May 17, 2024
e4cb5fc
revert: unnecessary usage of fluent API
jdrueckert May 17, 2024
2f15a82
qa: address remaining PMD guardlogstatement warnings
jdrueckert May 17, 2024
eb7ed68
Merge branch 'develop' into qa/fluent-logger
jdrueckert May 17, 2024
4ad29ed
fix: log format
jdrueckert May 17, 2024
f4b34ff
Merge remote-tracking branch 'origin/qa/fluent-logger' into qa/fluent…
jdrueckert May 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@

logger.info("World seed: \"{}\"", worldInfo.getSeed()); //NOPMD

// TODO: Separate WorldRenderer from world handling in general

Check warning on line 100 in engine/src/main/java/org/terasology/engine/core/modes/loadProcesses/InitialiseWorld.java

Terasology Jenkins.io / Open Tasks Scanner

TODO

NORMAL: Separate WorldRenderer from world handling in general
WorldGeneratorManager worldGeneratorManager = context.get(WorldGeneratorManager.class);
WorldGenerator worldGenerator;
try {
@@ -105,7 +105,7 @@
// setting the world seed will create the world builder
worldGenerator.setWorldSeed(worldInfo.getSeed());
context.put(WorldGenerator.class, worldGenerator);
} catch (UnresolvedWorldGeneratorException e) {
} catch (UnresolvedWorldGeneratorException | UnresolvedDependencyException e) {
logger.atError().log("Unable to load world generator {}. Available world generators: {}",
worldInfo.getWorldGenerator(), worldGeneratorManager.getWorldGenerators());
context.get(GameEngine.class).changeState(new StateMainMenu("Failed to resolve world generator."));

Unchanged files with check annotations Beta

"Please report this issue on Discord/GitHub and select a different world generator!");
e.printStackTrace();
} catch (UnresolvedDependencyException e) {
//TODO: this will likely fail at game creation time later-on due to lack of world generator - don't just ignore this

Check warning on line 361 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/UniverseSetupScreen.java

Terasology Jenkins.io / Open Tasks Scanner

TODO

NORMAL: this will likely fail at game creation time later-on due to lack of world generator - don't just ignore this
e.printStackTrace();
}