Set macOS deployment target to 10.10 to follow pospec #1444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 82.92% 88.41% +5.48%
==========================================
Files 5 5
Lines 164 164
==========================================
+ Hits 136 145 +9
+ Misses 28 19 -9
Continue to review full report at Codecov.
|
|
@SD10 according to #1441 (comment):
|
There was a problem hiding this comment.
Looks good, @lucas34, thanks for doing that - looks good! Can you also add a Changelog entry that we fixed Carthage macOS deployment target, from 10.11 to 10.10? 😉 It should be under Fixed column, which is already created in Changelog.md.
|
Sure, I removed the merge commit |
Changelog.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Next | |||
| ### Fixed | |||
| - Fixed a bug with missing Content-Type header when using `.requestJSONEncodable` [#1410](https://github.com/Moya/Moya/pull/1410) by [@Vict0rS](https://github.com/Vict0rS). | |||
| - Fixes carthage OS X not targeting 10.10 [#1444](https://github.com/Moya/Moya/pull/1444) by [@lucas34](https://github.com/lucas34). | |||
There was a problem hiding this comment.
This is minor, but can you change Fixes to Fixed, please? :)
|
Looks like @BasThomas added the merge commit back. Is it ok ? |
|
Yup, it looks great. Oh interesting, the merge commits are from the GitHub CTA... I wonder if they show up in the history of |
|
Thanks a lot for contributing to Moya! I've invited you to join the Moya GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions. |
|
Wow, that's incredibly annoying Github adds them as clean merges, complete noise. |
Link to issue #1441
Solve macOS deployment target discrepancy when using Carthage or pod.
I updated for all target. Moya, MoyaTest, RxMoya and ReactiveMoya.