requestAnimationFrame recursion on mobile

[itsthisjustin]

As seen here: #54 (comment)

I'm getting the same issue. Even the sample projects present this problem on all mobile browsers. I see on Firefox, Chrome (with flags for webvr set) and oddly enough on the Firefox nightly on Android tapping the headset icon just makes the experience full screen.

[cvan]

Thanks for digging this up from the comment and filing an issue. I'm going to take a look at this.

[cvan]

@itsthisjustin @caseyyee @delapuente: can you try checking out my branch in PR #132, and see it fixes things for you?

what are your steps to reproduce? just load https://mozilla.github.io/unity-webvr-export/ on one of your devices?

• Firefox for Android (Note 8)
• Chrome for Android (Note 8)
• Safari (iPhone X)

correct me if I'm missing something.

[cvan]

Original source was commented in #54 (comment):

[itsthisjustin]

On Firefox Stable the error still shows up in the console, however on both Chrome and Canary on Android, the experience doesn't crash anymore. It also now shows me the "VR Ready" icon which didn't previously show up.

[caseyyee]

@itsthisjustin this is definetly an issue we need to fix (raf errors), but just as a note, mobile is unreliable at best and not officially supported. Mobile browsers and devices generally don't have the memory and power to run these experiences well unfortunately!

[itsthisjustin]

@caseyyee yeah I guess that's going to depend largely upon how WebGL and WebVR are "handled" moving forward. The main page of webvr touts Cardboard as it's baseline way to experience the technology.

So if this Unity asset doesn't officially support mobile, it might not be good to say it's an export to webVR then since WebVR officially DOES support mobile.

[itsthisjustin]

Update: iPhone X with Safari gives the Maximum Call Stack error

[caseyyee]

@itsthisjustin It's not actually a limitation of WebGL or WebVR. Mobile devices unfortunately simply don't have the power or memory to run Unityplayer well.

[cvan]

@caseyyee how should we go about updating the webvr-polyfill to include this patch (or the changes within this patch)? immersive-web/cardboard-vr-display@6f6a0c1

we don't want to upgrade the webvr-polyfill (#113) because of the changes required (#125).

and the webvr-polyfill.min.js is obviously minified. (this is going to get gross, heh, brb…)

[caseyyee]

@cvan probably just need to wait till we get fps controls in first. I don't think we can do much otherwise we lose fallback controls. Makes sense to prioritize #125 so we can get this polyfill updated sooner rather than later.

[cvan]

@caseyyee see the PR I opened yesterday: https://github.com/mozilla/unity-webvr-export/pull/175/files

[cvan]

this is fixed by PR #175. @itsthisjustin: could you please try the version on master and let us know if it resolves your issue? thank you!