Add code linting and CI checks #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Errors show up in diff correctly. |
This reverts commit 88998f3.
ESLint removed a bunch of formatting-related rules on the assumption that autoformatters like Prettier handle them and do a better job. For some cases, that's great; we can remove the rule and delegate to prettier. For others, we need the rule, which has moved out of ESLint core and into `@stylistic/eslint-plugin-js` (e.g. Prettier does not police the length of comments).
Mr0grog
force-pushed
the
75-linting-is-table-stakes-and-yet-it-is-new-here
branch
from
ac2cd3d to
d21ec97
Compare
|
Did some final cleanup here (a few config bits different than #103, some deprecations in ESLint) and rebased on |
Mr0grog
deleted the
75-linting-is-table-stakes-and-yet-it-is-new-here
branch
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #103. There are no real issues with that PR, but there have been a bunch of source changes since it was proposed that cause conflicts. It's easier to copy the configs over and re-correct things than adapt that branch.
Starting with just ESLint and testing CI, then will add Prettier.