Install correct Chromedriver version #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests recently started failing in GitHub actions, and it's because the pre-installed version of Chrome and the version of Chromedriver specified in
package.json
fell out of sync. This installs the latest Chromedriver, but also adds some NPM configuration options to make this future-proof by installing the correct, matching versions of Chromedriver and Chromium itself, rather than the specific on inpackage.json
.As a side note, it seems like we should only need to specify
include_chromium=true
(so we have a version of Chromium that matches Chromedriver), but that setting is ignored unlessdetect_chromedriver_version=true
is also set, which seems counterintuitive to me (if you are installing a compatible chromium, you shouldn’t need to detect the version, since you are installing a known-compatible version, but maybe I’ve got the mental model wrong here).