forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Subscription size backend integration #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…button for the second time"
…nt_unvalidated_signup Implement unvalidated signups for newDot
…1336 [CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time"
…nitCrash [CP Staging] Fix crash when submitting expense on a newly created workspace
[No QA] Use double negation instead of Boolean()
…n-call Replace Boolean by !!
…patch-3 Update en.ts
fix: Distance unit isn't updated immediately
…omTabBar [Search v1] Implement Bottom Tab Bar Changes
feature: Add validation flow to bank account set up
…ns-temporarilyDisableQueries [No QA] Revert "[No QA] Temporarily disable queries that are not implemented yet"
…sactionThreadIfNeeded Create transaction thread if needed
move message "admins only can post" from welcome message to footer
…DetailsSection [Payment card / Subscription] Polish "Subscription details" section with useThemeIllustrations
Prevent crash when connecting to QuickBooks Online
…patch-4 [NO Qa] Copy Update for Expensify documentation
…/41440 feat: [Held requests] option does not show in the preview overflow menu.
…able-deleted-parent-action-while-offline Fix can't interact with deleted parent action after deleting it for a while
…scription-size-backend-integration
…voiceroom-option Stop showing archived invoice room as an option in participants picker
…p into feat/subscription-size-backend-integration
…scription-size-action
…p into feat/subscription-size-backend-integration
…eport-in-lhn Apply useOnyx in LHNOptionsList
…ateIDOnWriteRequests [No QA] Add client updateID on write requests
…e-action feat: subscription size action
…scription-size-backend-integration
MrMuzyk
pushed a commit
that referenced
this pull request
Sep 19, 2024
Coming from chat with Carlos, adding > It is required to complete every step and check every box in the PR Author Checklist. If a box has been checked without the action being taken, it will be a violation of Rule #2 and could lead to a warning being issued.
MrMuzyk
pushed a commit
that referenced
this pull request
Oct 10, 2024
…le-overflown #2 - Fix task title is overflown and align the checkbox and arrow correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Integrated Subscription Size parts with backend. Data now comes from API and proper API calls are performed when exectued
Fixed Issues
$ Expensify#38631
Tests
To access this newly created component, paste the following link into the browser
https://dev.new.expensify.com:8082/settings/subscription
or add this effect to InitialSettingsPage.tsx
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
sub-size-ba-integration.mp4