-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test coverage commands #112
Conversation
ef6a25f
to
8c48fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not fully understand the idea. Why do we need both html and xml? And why do we generate html by default. Why cannot we just use stdout? With a simple --cov=chispa
it will print a nice and readable message with summary about coverage.
I would like to see the stdout message on a make test
and html/xml reports should be generated by test-coverage
or something like this.
Also, for example, I do not have an open
command (xdg-open
should be used instead). What do you think about removing open
and generate only reports?
@SemyonSinchenko Sorry, I could have elaborated a bit more in the PR description. The idea is to have:
Hope this clarifies! I modified the commands and removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. I left one minor comment. Feel free to merge when you are done.
5890b7a
to
771b9fc
Compare
No description provided.