Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove vendored dependency prettytable #114

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

fpgmaas
Copy link
Collaborator

@fpgmaas fpgmaas commented Jul 17, 2024

Currently, the project has prettytable as a vendored dependency. This seems superfluous, we can add it as a regular dependency.

Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is out of the scope of the PR, may we create and start filling the NOTICE file? We need to do it sooner or later anyway. Let's include this notice (about binary, because we are using it as whl from PyPI) to NOTICE-binary.md? What do you think @fpgmaas ?

That is an example of NOTICE-binary.md in Spark itself.

@fpgmaas
Copy link
Collaborator Author

fpgmaas commented Jul 17, 2024

While it is out of the scope of the PR, may we create and start filling the NOTICE file? We need to do it sooner or later anyway. Let's include this notice (about binary, because we are using it as whl from PyPI) to NOTICE-binary.md? What do you think @fpgmaas ?

That is an example of NOTICE-binary.md in Spark itself.

I am not familiar with that file @SemyonSinchenko . Shall we leave that for a separate PR, since it seems unrelated?

@SemyonSinchenko
Copy link
Collaborator

While it is out of the scope of the PR, may we create and start filling the NOTICE file? We need to do it sooner or later anyway. Let's include this notice (about binary, because we are using it as whl from PyPI) to NOTICE-binary.md? What do you think @fpgmaas ?
That is an example of NOTICE-binary.md in Spark itself.

I am not familiar with that file @SemyonSinchenko . Shall we leave that for a separate PR, since it seems unrelated?

Yes we can postpone it. Leave it on me.

@SemyonSinchenko SemyonSinchenko merged commit b4a98b7 into MrPowers:main Jul 17, 2024
7 checks passed
@fpgmaas fpgmaas deleted the feat/prettytable branch July 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants