More bucket tool optimizations #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is useless for release build as the compiler will optimize this, but for debug builds this results in a roughly 3x speed improvment.
This treats everything outside the minimally bounded target image as a single region (which it is). compareColor only needs to be called once, and if it's true, then all of the transparent "border" region can be filled at once. Ideally this would be done with a rectangular fill with a mask when creating replaceImage, but unforunately that information needs to be present in filledPixels if expandFill is run. Thankfull this is pretty fast anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some room for improvement, but this will the last of them from me for now.