Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for Etsy.com? #268

Open
al-the-x opened this issue Jun 18, 2015 · 3 comments
Open

Add module for Etsy.com? #268

al-the-x opened this issue Jun 18, 2015 · 3 comments
Labels

Comments

@al-the-x
Copy link

Curious if there's interest in a module for Etsy.com's API, which uses OAuth 1.0: https://www.etsy.com/developers/documentation/getting_started/oauth

BONUS FEATURE

In addition to the regular OAuth parameters, Etsy requires the inclusion of an api_key query parameter for all requests. Could the OAuth proxy service be modified to include that parameter to avoid exposure in client-side JavaScript?

@MrSwitch
Copy link
Owner

MrSwitch commented Jul 2, 2015

Yes there is interest.

Try augment the login request. Here's how to do it to a module....

...
login: function(p) {
   p.qs.oauth.auth += "?api_key="+p.qs.client_id;
}
...

@al-the-x
Copy link
Author

al-the-x commented Jul 3, 2015

The login request that you're referring to is the one provided by hello.js, correct? I was referring to augmenting the OAuth proxy service to allow the configuration of additional QS parameters... But additional requests from the library don't go through the OAuth proxy service anyway, do they... So nevermind.

al-the-x added a commit to al-the-x/hello.js that referenced this issue Jul 3, 2015
@MrSwitch
Copy link
Owner

MrSwitch commented Jul 3, 2015

Please see how this is overcome using the Tumblr facade as an example https://github.com/MrSwitch/hello.js/blob/master/src/modules/tumblr.js#L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants