Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong module usage on v2 #507

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Fix wrong module usage on v2 #507

merged 2 commits into from
Jul 10, 2017

Conversation

sigerello
Copy link

Hi,
You use param module from tricks package here to construct query string from object, but you also mistakenly use the same module to parse query string here, here and here instead of using queryparse package.
This leads to error Uncaught TypeError: str.replace is not a function when using with oauth-shim package and oauth_proxy option.

Here is the fix.

@MrSwitch MrSwitch merged commit 77deb40 into MrSwitch:v2 Jul 10, 2017
@MrSwitch
Copy link
Owner

Ahh thanks, i'm clearly missing some tests here. Thanks @sigerello you've really delved into the stack and nailed this PR.

MrSwitch added a commit that referenced this pull request Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants