Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icon to Windows binary #25

Merged
merged 6 commits into from
Nov 7, 2022
Merged

Conversation

nozwock
Copy link
Contributor

@nozwock nozwock commented Nov 7, 2022

Addressing #9 by implementing solution #1

@nozwock
Copy link
Contributor Author

nozwock commented Nov 7, 2022

Currently using icon-64x64.ico for Icon resource.

Screenshot

@nozwock
Copy link
Contributor Author

nozwock commented Nov 7, 2022

Btw should I merge these few refactors aswell or create a separate PR for it instead?

Cargo.toml Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
build.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@MrTanoshii MrTanoshii mentioned this pull request Nov 7, 2022
@MrTanoshii
Copy link
Owner

Btw should I merge these few refactors aswell or create a separate PR for it instead?

Separate PR please

Copy link
Contributor Author

@nozwock nozwock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate changes have been made, hmm I don't understand how reviews are supposed to work...what now :-P

@nozwock nozwock requested a review from MrTanoshii November 7, 2022 12:16
@MrTanoshii MrTanoshii added the enhancement New feature or request label Nov 7, 2022
@MrTanoshii MrTanoshii linked an issue Nov 7, 2022 that may be closed by this pull request
@MrTanoshii MrTanoshii merged commit a23d4d9 into MrTanoshii:main Nov 7, 2022
@MrTanoshii
Copy link
Owner

@MrTanoshii Test fails because lib doesn't exist anymore, here

Should I make changes to the Rust check workflow?

Sure, we can actually get rid of the whole job in a new PR.

test:
name: Test Suite
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
- name: Setup device_query dependencies
run: sudo apt-get install libx11-dev
- name: Setup rdev dependencies
run: sudo apt-get --assume-yes install libxtst-dev libevdev-dev
- name: Setup eframe dependencies
run: sudo apt-get install libxcb-render0-dev libxcb-shape0-dev libxcb-xfixes0-dev libspeechd-dev libxkbcommon-dev libssl-dev
- uses: actions-rs/cargo@v1
with:
command: test
args: --verbose --lib

@nozwock nozwock deleted the add-icon-windows branch November 7, 2022 12:37
@nozwock nozwock mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon to binary file
2 participants