This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Make node manager locks RwLocks #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
commented
Feb 6, 2024
Comment on lines
+1101
to
+1105
| // get nodes hashmap, immediately drop lock because sync can take a while | ||
| let nodes = { | ||
| let nodes = self.nodes.read().await; | ||
| nodes.deref().clone() | ||
| }; |
There was a problem hiding this comment.
this is the main change that fixed the issue
TonyGiorgio
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #925
Pulled out from #1002
This was breaking tests in the above PR because the syncing background thread would block us from making other calls (ie get balance). This fixes by putting it in a
RwLockinstead of in a genericMutexas well as making us drop the lock after reading the nodes we are gonna sync instead of holding it during the entire sync duration