-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mint discoverability #1060
Mint discoverability #1060
Conversation
07111c5
to
cccc1ee
Compare
cccc1ee
to
32797ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the primal commit needs to be fixed and merged first
needs rebase |
aa1fc06
to
1d01bf0
Compare
Implemented so now we check against primal's list of trusted users. Made it so we can see recommended federations even if they haven't announced themselves on nostr Added the ability to recommend federations. |
1d01bf0
to
6af8528
Compare
vec![invite_code.to_string(), "fedimint".to_string()], | ||
); | ||
|
||
// todo tag the federation announcement event, to do so we need to have the pubkey of the federation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't really possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to save the pubkey of it when we add it from recommendations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little unsure how this is supposed to work and link together. Is it just by the d_tag
being the same across reviews? Does the federation invite code even need to be here? Should we pull down the other federation members invite code's to put in the vec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just by the d_tag being the same across reviews?
Yeah the d tag is the federation id
Does the federation invite code even need to be here?
Yeah, in the case the federation has not announced itself
Should we pull down the other federation members invite code's to put in the vec?
We could... I figured since it is a recommendation, they recommend the code they are using, maybe that is the most reliable member in the federation.
87ae5bc
to
bb42fae
Compare
Also, is this up to date with the latest of the spec? |
Yeah |
bb42fae
to
b98c557
Compare
rebased |
basic implementation of: nostr-protocol/nips#1110
we should probably also add support for creating a recommendation event for federations we've joined