Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blindauth first pass #1067

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Blindauth first pass #1067

merged 5 commits into from
Mar 25, 2024

Conversation

TonyGiorgio
Copy link
Contributor

No description provided.

@TonyGiorgio TonyGiorgio force-pushed the blindauth branch 2 times, most recently from 3d83741 to 923c4ab Compare March 19, 2024 22:17
@TonyGiorgio
Copy link
Contributor Author

This could use an intermittent review @benthecarman

There will certainly need to have a few more methods in the blind auth client, but this structure should be complete as far as creating blind messages and stuff.

benthecarman
benthecarman reviewed Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking good

mutiny-core/src/blindauth.rs Outdated Show resolved Hide resolved
mutiny-core/src/blindauth.rs Outdated Show resolved Hide resolved
mutiny-core/src/blindauth.rs Outdated Show resolved Hide resolved
mutiny-core/src/blindauth.rs Outdated Show resolved Hide resolved
@TonyGiorgio TonyGiorgio force-pushed the blindauth branch 5 times, most recently from eb32dd8 to f41b824 Compare March 20, 2024 22:50
benthecarman
benthecarman reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far

mutiny-core/src/blindauth.rs Outdated Show resolved Hide resolved
mutiny-core/src/blindauth.rs Outdated Show resolved Hide resolved
mutiny-core/src/hermes.rs Outdated Show resolved Hide resolved
mutiny-core/src/hermes.rs Outdated Show resolved Hide resolved
mutiny-core/src/hermes.rs Outdated Show resolved Hide resolved
mutiny-core/src/hermes.rs Outdated Show resolved Hide resolved
mutiny-core/src/hermes.rs Outdated Show resolved Hide resolved
mutiny-core/src/nostr/mod.rs Outdated Show resolved Hide resolved
@TonyGiorgio TonyGiorgio force-pushed the blindauth branch 4 times, most recently from aee12fe to 63fc2eb Compare March 21, 2024 22:37
@TonyGiorgio
Copy link
Contributor Author

Need to check for tokens after subscribing to mutiny+

@benthecarman benthecarman self-requested a review March 25, 2024 17:44
@TonyGiorgio TonyGiorgio marked this pull request as ready for review March 25, 2024 17:45
@TonyGiorgio TonyGiorgio changed the title Blindauth wip Blindauth first pass Mar 25, 2024
benthecarman
benthecarman approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good enough base for now, won't nit pick you to death :)

@TonyGiorgio TonyGiorgio merged commit 25d56ce into master Mar 25, 2024
9 checks passed
@TonyGiorgio TonyGiorgio deleted the blindauth branch March 25, 2024 18:05
@benthecarman
Copy link
Collaborator

Made an issue from all the TODOs in here #1079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyGiorgio @benthecarman