Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Wrap fedimint around an async rwlock #924

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Wrap fedimint around an async rwlock #924

merged 1 commit into from
Jan 2, 2024

Conversation

TonyGiorgio
Copy link
Contributor

No description provided.

benthecarman
benthecarman approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I presume this is needed because before we couldn't read at the same time but with this we can

@TonyGiorgio
Copy link
Contributor Author

lgtm, I presume this is needed because before we couldn't read at the same time but with this we can

Correct, it was blocking the activity list while a fedimint payment was being made.

@benthecarman
Copy link
Collaborator

There's probably other places in the codebase we can do this too, would be a good followup

@benthecarman benthecarman mentioned this pull request Jan 2, 2024
Closed
@benthecarman benthecarman merged commit 2f0b903 into master Jan 2, 2024
9 checks passed
@benthecarman benthecarman deleted the fedimint-async-lock branch January 2, 2024 23:30
@TonyGiorgio TonyGiorgio mentioned this pull request Jan 3, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyGiorgio @benthecarman