-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create index for sorted activity #999
Conversation
75dc19c
to
3548c9f
Compare
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3548c9f
to
5baaa28
Compare
Fixed all the duplication errors which also seemed to fixed the crashing for me too, curious if it helps for you as well. |
70a7ba1
to
074a546
Compare
074a546
to
dd45cc4
Compare
What if we did this and defaulted the activity list to the last ~30 items? My phone is starting to get very slow. And having the new social home screen basically being a "view all" for the transaction list, I would rather it not be that much. |
Makes sense to me, can rebase |
1ee255a
to
20dce22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. If you just want to test it to make sure it works with the new mutiny social PR, that would be great.
20dce22
to
319293e
Compare
Found a potential index out of bounds error when testing, fixed it and added tests. Otherwise everything else felt good |
319293e
to
42954ff
Compare
sorry last push, chatgpt told me another check to add just in case:
|
42954ff
to
6dcc05c
Compare
Now keeps a sorted index of our activity at all time. This should make our activity much faster with only a slight overhead increase.