BQ exception should be raised first before we check the timedout (fea…

…st-dev#1675) Signed-off-by: Matt Delacour <[email protected]> Signed-off-by: Mwad22 <[email protected]>
Mwad22 · Jul 7, 2021 · 651bce3 · 651bce3
1 parent d36d1a0
commit 651bce3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py
@@ -288,13 +288,13 @@ def _wait_until_done(job_id):
     job_id = bq_job.job_id
     _wait_until_done(job_id=job_id)
 
+    if bq_job.exception():
+        raise bq_job.exception()
+
     if not _is_done(job_id):
         client.cancel_job(job_id)
         raise BigQueryJobCancelled(job_id=job_id)
 
-    if bq_job.exception():
-        raise bq_job.exception()
-
 
 @dataclass(frozen=True)
 class FeatureViewQueryContext: