MIR-1393 PMD rule MissingSerialVersionUID

mir-module/src/main/java/org/mycore/mir/MIRClassificationServlet.java

@@ -1,5 +1,6 @@
 package org.mycore.mir;
 
+import java.io.Serial;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
@@ -21,6 +22,7 @@
 
 public class MIRClassificationServlet extends MCRServlet {
 
+    @Serial
     private static final long serialVersionUID = 1L;
 
     private static final String LAYOUT_ELEMENT_KEY = MIRClassificationServlet.class.getName() + ".layoutElement";

mir-module/src/main/java/org/mycore/mir/MIRGetOpenAIREProjectsServlet.java

@@ -2,6 +2,7 @@
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.Serial;
 import java.net.URI;
 import java.net.URLEncoder;
 import java.net.http.HttpClient;
@@ -20,6 +21,7 @@
 
 public class MIRGetOpenAIREProjectsServlet extends HttpServlet {
 
+    @Serial
     private static final long serialVersionUID = 1L;
 
     private static Logger LOGGER = LogManager.getLogger();

mir-module/src/main/java/org/mycore/mir/MIRStateServlet.java

@@ -1,5 +1,6 @@
 package org.mycore.mir;
 
+import java.io.Serial;
 import java.util.Arrays;
 import java.util.Optional;
 
@@ -20,6 +21,9 @@
 
 public class MIRStateServlet extends MCRServlet {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     protected static final String X_NEXT_LANGUAGE = "x-next";
 
     @Override

mir-module/src/main/java/org/mycore/mir/authorization/MirSelfRegistrationServlet.java

@@ -59,7 +59,7 @@
 public class MirSelfRegistrationServlet extends MCRServlet {
 
     @Serial
-    private static final long serialVersionUID = -7105234919911900795L;
+    private static final long serialVersionUID = 1L;
 
     private static final Logger LOGGER = LogManager.getLogger();
 

mir-module/src/main/java/org/mycore/mir/authorization/accesskeys/backend/MIRAccessKey.java

@@ -52,8 +52,6 @@
 @Table(name = "miraccesskey")
 public class MIRAccessKey {
 
-    private static final long serialVersionUID = 1L;
-
     /** The unique and internal information id */
     private int id;
 

mir-module/src/main/java/org/mycore/mir/authorization/accesskeys/backend/MIRAccessKeyPair.java

@@ -20,6 +20,7 @@
 
 package org.mycore.mir.authorization.accesskeys.backend;
 
+import java.io.Serial;
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
@@ -76,6 +77,7 @@ public class MIRAccessKeyPair implements Serializable {
 
     public static final String PERMISSION_WRITE = "write";
 
+    @Serial
     private static final long serialVersionUID = 1L;
 
     private MCRObjectID mcrObjectId;

mir-module/src/main/java/org/mycore/mir/authorization/accesskeys/frontend/servlet/MIRAccessKeyServlet.java

@@ -34,8 +34,11 @@
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
 
+import java.io.Serial;
+
 public class MIRAccessKeyServlet extends MCRServlet {
 
+    @Serial
     private static final long serialVersionUID = 1L;
 
     private static final String REDIRECT_URL_PARAMETER = "url";

mir-module/src/main/java/org/mycore/mir/index/MirSolrFileStrategy.java

@@ -1,6 +1,7 @@
 package org.mycore.mir.index;
 
 import java.io.InputStream;
+import java.io.Serial;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.attribute.BasicFileAttributes;
@@ -63,6 +64,9 @@ public void startElement(String uri, String localName, String qName, Attributes
 
     private static class ProbeXMLException extends RuntimeException {
 
+        @Serial
+        private static final long serialVersionUID = 1L;
+
         private String rootName;
 
         private ProbeXMLException(String rootName) {

mir-module/src/main/java/org/mycore/mir/orcid/MIROrcidServlet.java

@@ -1,6 +1,7 @@
 package org.mycore.mir.orcid;
 
 import java.io.IOException;
+import java.io.Serial;
 import java.net.MalformedURLException;
 import java.net.URI;
 import java.net.URISyntaxException;
@@ -34,6 +35,9 @@
 
 public class MIROrcidServlet extends MCRServlet {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     private static final String ORCID_URL = "https://orcid.org/";
 
     private static final String ORCID_API_URL = "https://pub.orcid.org/";

mir-wizard/src/main/java/org/mycore/mir/wizard/MIRWizard.java

@@ -31,11 +31,13 @@
 import org.mycore.frontend.servlets.MCRServlet;
 
 import java.io.File;
+import java.io.Serial;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
 
 public class MIRWizard extends MCRServlet {
 
+    @Serial
     private static final long serialVersionUID = 1L;
 
     private static final Logger LOGGER = LogManager.getLogger();

mir-wizard/src/main/java/org/mycore/mir/wizard/MIRWizardServlet.java

@@ -23,6 +23,7 @@
 package org.mycore.mir.wizard;
 
 import java.io.IOException;
+import java.io.Serial;
 import java.util.StringTokenizer;
 
 import org.apache.logging.log4j.LogManager;
@@ -46,6 +47,7 @@
  */
 public class MIRWizardServlet extends MCRServlet {
 
+    @Serial
     private static final long serialVersionUID = 1L;
 
     private static final Logger LOGGER = LogManager.getLogger();

ruleset.xml

@@ -251,10 +251,7 @@
   <rule ref="category/java/errorprone.xml/JUnitStaticSuite"/>
   <rule ref="category/java/errorprone.xml/MethodWithSameNameAsEnclosingClass"/>
   <rule ref="category/java/errorprone.xml/MisplacedNullCheck"/>
-  <!-- TODO: Create PR to fix this rule -->
-  <!--
   <rule ref="category/java/errorprone.xml/MissingSerialVersionUID"/>
-  -->
   <rule ref="category/java/errorprone.xml/MissingStaticMethodInNonInstantiatableClass"/>
   <rule ref="category/java/errorprone.xml/MoreThanOneLogger"/>
   <rule ref="category/java/errorprone.xml/NonCaseLabelInSwitch"/>