Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIR-1285 Display realname rather than uid of user after login #971

Conversation

Possommi
Copy link
Contributor

@Possommi Possommi commented Mar 8, 2024

@Possommi Possommi requested a review from toKrause March 8, 2024 10:42
@Possommi Possommi force-pushed the issues/MIR-1285-Display-realname-rather-than-uid-of-user-after-login branch from be6d3ad to 35cdb34 Compare March 8, 2024 11:16
Copy link
Contributor

@toKrause toKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs coordination with MIR-1288

This implementation uses the name, if available, in the UI. MIR-1288 still uses the user ID.

@fluetze
Copy link
Member

fluetze commented Mar 11, 2024

A user's real name is typically much wider than the user ID. So this change will affect the layout of MIR instances nad might be unwanted. Or is there any customization option?

@Possommi
Copy link
Contributor Author

A user's real name is typically much wider than the user ID. So this change will affect the layout of MIR instances nad might be unwanted. Or is there any customization option?

At the moment this is not configurable.

@kkrebs
Copy link
Contributor

kkrebs commented Mar 14, 2024

@Possommi and @toKrause - will we try this as it is? Or should it be configurable?

@toKrause
Copy link
Contributor

Since this is a behavior change that targets the LTS branch, the change should technically
be optional, i.e. configurable. But this specific change is so undramatic that I wouldn't insist on that.

@Possommi
Copy link
Contributor Author

Possommi commented Mar 14, 2024

I am with @toKrause on this matter.

From user perspective it's more friendly to read the name rather than the uid. In particular when a user is signed in via SSO where the username could be anything (uid, scroped attribute or even some sort of uuid).

@sebhofmann
Copy link
Member

This will break our (crappy) Javascripts in some of our applications, but since we are not on 2023 with any of them it should be ok.

@Possommi
Copy link
Contributor Author

I will introduce a new property making the behaviour configurable

@Possommi Possommi force-pushed the issues/MIR-1285-Display-realname-rather-than-uid-of-user-after-login branch from 8c75822 to 3304a8b Compare March 15, 2024 08:33
@Possommi
Copy link
Contributor Author

Possommi commented Mar 15, 2024

A user's real name is typically much wider than the user ID. So this change will affect the layout of MIR instances nad might be unwanted. Or is there any customization option?

@fluetze @kkrebs @sebhofmann I added a property and the default behaviour remains unchanged

@kkrebs kkrebs merged commit ea5297e into 2023.06.x Mar 26, 2024
2 checks passed
@kkrebs kkrebs deleted the issues/MIR-1285-Display-realname-rather-than-uid-of-user-after-login branch March 26, 2024 14:56
yagee-de added a commit that referenced this pull request Apr 26, 2024
* 2023.06.x:
  MIR-1288 add acl for displaying submitted document (#980)
  MIR-1302 update to current pica2mods release 2.10
  MIR-1300 encode directory path as well
  MIR-1304 Revert "MIR-1198 Support validation of PDF/A documents (#900)" (#995)
  MIR-1301 fix wrong path to pica stylesheet
  MIR-1291 Added property #MCR.Access.Strategy.CreatorAnyStatePermissions=read-history and use acl to determine access right as of MyCoRe-Org/mycore#2110
  MIR-1296 Do not allow to select current document as relatedItem
  MIR-1285 Display realname rather than uid of user after login (#971)
  MIR-1295 Get text for state badge from classification (#983)
  MIR-1294 wrong include in mycoreobject-datacite-mir.xsl
  MIR-1292 MIR-1293 Updated template datacite2mods.xsl to support ORCID ids given by url (#977)
  MIR-1289 Cancel button redirects to $RequestURL in editor-derivate.xed
  MIR-1288 allow listing of submitted documents for current user
  MIR-1284 use Xalan for mycoreobject-compress
  MIR-1280 Links from details page to name identifier based name search not working (#959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants