MIR-1329 Reenable support for validation of PDF/A documents #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebhofmann
requested changes
Apr 26, 2024
There was a problem hiding this comment.
No Ticket number, it needs to be MIR-1304. The Bug https://mycore.atlassian.net/browse/MIR-1303 should also be solved before merging this back.
|
There should also be a property to disable this, without disabling the whole workflow. |
toKrause
changed the title
toKrause
changed the title
Antoniafriedrich
force-pushed
the
revert-995-issues/MIR-1304-remove_validation_until_validation_frequency_improved
branch
from
197d08d to
43e9eda
Compare
Antoniafriedrich
force-pushed
the
revert-995-issues/MIR-1304-remove_validation_until_validation_frequency_improved
branch
from
5a3fcdd to
ee78080
Compare
Antoniafriedrich
force-pushed
the
revert-995-issues/MIR-1304-remove_validation_until_validation_frequency_improved
branch
from
ee78080 to
7112add
Compare
sebhofmann
requested changes
Oct 21, 2024
| @@ -733,7 +733,7 @@ MCR.Object.Static.Content.Generator.mir-history.Transformer=mir-history | |||
| MCR.URIResolver.xslImports.mirworkflow=metadata/mir-workflow.xsl | |||
| MIR.Workflow.Menu=false | |||
| MIR.Workflow.Box=false | |||
|
|
|||
| MIR.EnablePdfaValidationInWorkflow=false | |||
There was a problem hiding this comment.
I would prefer something like MIR.Workflow.PDFValidation
| <xsl:if test="not(normalize-space($result))"> | ||
| <xsl:apply-templates select="$result/derivate/file" mode="displayPdfError"/> | ||
| </xsl:if> | ||
| <xsl:variable name="derivbase" select="concat($ServletsBaseURL,'MCRFileNodeServlet/',$result/derivate/@id,'/')" /> |
| xmlns:xalan="http://xml.apache.org/xalan" | ||
| version="1.0" exclude-result-prefixes="i18n mcrxsl"> | ||
|
|
||
| <xsl:param name="WebApplicationBaseURL"/> |
| </div> | ||
| </div> | ||
| </xsl:when> | ||
| <xsl:when test="string-length(normalize-space($errorMessages)) > 0 and not(contains($errorMessages,'Clause'))"> |
There was a problem hiding this comment.
and not(contains($errorMessages,'Clause')) is not necessary
|
|
||
| <xsl:template match="structure/derobjects/derobject" mode="displayPdfError"> | ||
| <xsl:variable name="derivateID" select="@xlink:href"/> | ||
| <xsl:variable name="result" select="document(concat('pdfAValidator:', $derivateID))"/> |
There was a problem hiding this comment.
There should be a notNull or exception uri resolver chained in, to prevent the resolver from crashing the whole metadata page like in MIR-1303
There was a problem hiding this comment.
I am working on that ticket seperately and will be merging it into this branch in a seperate pull request.
| <div id="{$derivate}{$uniqueFileId}" class="font-weight-bold d-flex list-group list-group-root"> | ||
| <a onclick="$('#{$derivate}{$uniqueFileId}cbButton').toggleClass('fa-chevron-right fa-chevron-down');" | ||
| data-toggle="collapse" href="#collapse{$derivate}{$uniqueFileId}" | ||
| class="text-left d-flex flex-md-row flex-grow-1 list-group-item align-items-center"> |
There was a problem hiding this comment.
Unnecessary space in @class attribute.
| <li class="list-group-item d-flex flex-column flex-xl-row flex-grow-1 text-break"> | ||
| <p class="flex-grow col-lg-8 col-md-9 align-self-center"> | ||
| <span class="text-muted pdf-term"> | ||
| Specification: |
| <xsl:value-of select="concat(' ', @specification, ' ')"/> | ||
| </span> | ||
| <span class="text-muted pdf-term"> | ||
| Clause: |
| <xsl:value-of select="concat(' ', @clause, ' ')"/> | ||
| </span> | ||
| <span class="text-muted pdf-term"> | ||
| Test: |
Adds a mycore property to enable PDF/A validation seperately to Mir Workflow. Default is false.
Adds translation, removes unused variables and fixes some minor issues
Antoniafriedrich
force-pushed
the
revert-995-issues/MIR-1304-remove_validation_until_validation_frequency_improved
branch
from
2b88614 to
7f1be80
Compare
|
Commits from "MIR-1303 Add handling for non-validatable PDF documents" merged upon request, for easier code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #995
Requires #1078