Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add TestCase for Value\Color #793

Merged
merged 1 commit into from
Jan 19, 2025
Merged

[TASK] Add TestCase for Value\Color #793

merged 1 commit into from
Jan 19, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Jan 19, 2025

This covers expected behaviour for CSS level 3
(some of which is also covered by more general tests).

Also included are some commented-out tests for CSS Color Module Level 4, support for which is yet to be implemented,
as well as for some syntaxes that should be rejected (but currently are not).

Precursor to resolving #755 and supporting CSS Color Module Level 4.

@JakeQZ JakeQZ added css3 testing PRs/issues adding additional tests only, or primarily testing-focused labels Jan 19, 2025
@JakeQZ JakeQZ requested a review from oliverklee January 19, 2025 01:50
@JakeQZ JakeQZ self-assigned this Jan 19, 2025
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Jan 19, 2025

@oliverklee, not sure how you feel about having commented-out tests, but it seemed to me, for now, a convenient way of capturing what needs to be done.

@coveralls
Copy link

coveralls commented Jan 19, 2025

Coverage Status

coverage: 40.95% (+1.1%) from 39.862%
when pulling 94448c2 on task/color-test
into 1312700 on main.

This covers expected behaviour for CSS level 3
(some of which is also covered by more general tests).

Also included are some commented-out tests for CSS Color Module Level 4,
support for which is yet to be implemented,
as well as for some syntaxes that should be rejected (but currently are not).

Precursor to resolving #755 and supporting CSS Color Module Level 4.
@oliverklee
Copy link
Contributor

not sure how you feel about having commented-out tests, but it seemed to me, for now, a convenient way of capturing what needs to be done.

I'm okay with those.

For still-to-be-done test cases, I prefer markTestIncomplete, and for still-to-be-done data provider cases, I slightly prefer // comments over /* */ comments as those make re-enabling single cases a bit less of a hassle.

@oliverklee oliverklee changed the title [TASK] Add TestCase for Value\Color [TASK] Add TestCase for Value\Color Jan 19, 2025
@oliverklee oliverklee merged commit 4d33faf into main Jan 19, 2025
21 checks passed
@oliverklee oliverklee deleted the task/color-test branch January 19, 2025 09:44
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Jan 19, 2025

I slightly prefer // comments over /* */ comments as those make re-enabling single cases a bit less of a hassle.

With

/*
someCode();
//*/

the code can be temporarily uncommented by simply adding a forward-slash at the start of the comment:

//*
someCode();
//*/

@oliverklee
Copy link
Contributor

@JakeQZ Is this something to backport?

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Jan 21, 2025

@JakeQZ Is this something to backport?

It would be needed if we wanted to backport #797 and its follow-up. But see #797 (comment). I think we are wasting our time with the backports, and should cut a 9.0 release as soon as #755 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css3 testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants