-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Add TestCase for Value\Color
#793
Conversation
@oliverklee, not sure how you feel about having commented-out tests, but it seemed to me, for now, a convenient way of capturing what needs to be done. |
d8f262b
to
bbbbcbe
Compare
This covers expected behaviour for CSS level 3 (some of which is also covered by more general tests). Also included are some commented-out tests for CSS Color Module Level 4, support for which is yet to be implemented, as well as for some syntaxes that should be rejected (but currently are not). Precursor to resolving #755 and supporting CSS Color Module Level 4.
bbbbcbe
to
94448c2
Compare
I'm okay with those. For still-to-be-done test cases, I prefer |
Value\Color
With /*
someCode();
//*/ the code can be temporarily uncommented by simply adding a forward-slash at the start of the comment: //*
someCode();
//*/ |
@JakeQZ Is this something to backport? |
It would be needed if we wanted to backport #797 and its follow-up. But see #797 (comment). I think we are wasting our time with the backports, and should cut a 9.0 release as soon as #755 is resolved. |
This covers expected behaviour for CSS level 3
(some of which is also covered by more general tests).
Also included are some commented-out tests for CSS Color Module Level 4, support for which is yet to be implemented,
as well as for some syntaxes that should be rejected (but currently are not).
Precursor to resolving #755 and supporting CSS Color Module Level 4.