[TASK] Drop PHP_CodeSniffer #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
task/drop-codesniffer
branch
from
cc19445 to
e4540be
Compare
The GPG keys used to sign the PHARs are no longer available, which breaks installation of PHP_CodeSniffer (and its fixer), which breaks the build. In `main`, we already dropped the tool in #468. Also update PHPStan as the old version was signed with a key that is no longer available.
oliverklee
force-pushed
the
task/drop-codesniffer
branch
from
e4540be to
b2647fc
Compare
oliverklee
added a commit
that referenced
this pull request
Jan 27, 2025
It has turned out that our current set of PHIVE-installed development tools for the V8.x maintenance branch is no longer installable due to issues with the GPG keys used for signing the PHARs. As the maintenance branch has very little activity anyway now, relying on PHP linting and the unit tests should suffice, saving us the hassle with PHIVE on that branch. (We're still keeping some `.gitignore` entries related to the tools to make switching branches easier.) Closes #831 Closes #830
JakeQZ
pushed a commit
that referenced
this pull request
Jan 27, 2025
It has turned out that our current set of PHIVE-installed development tools for the V8.x maintenance branch is no longer installable due to issues with the GPG keys used for signing the PHARs. As the maintenance branch has very little activity anyway now, relying on PHP linting and the unit tests should suffice, saving us the hassle with PHIVE on that branch. (We're still keeping some `.gitignore` entries related to the tools to make switching branches easier.) Closes #831 Closes #830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPG keys used to sign the PHARs are no longer available, which breaks installation of PHP_CodeSniffer (and its fixer), which breaks the build.
In
main, we already dropped the tool in #468.