Permissionless Pool Creation #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tonylee08
commented
Jan 30, 2025
tonylee08
commented
- Permissionless Creation
- Adding/removing stablecoins
- Updated VERSION constant
0xaslan
reviewed
Jan 30, 2025
0xaslan
approved these changes
Jan 31, 2025
| let _: &mut RegistryInner = self.load_inner_mut(); | ||
| let stable_type = type_name::get<StableCoin>(); | ||
| if ( | ||
| !dynamic_field::exists_( |
There was a problem hiding this comment.
instead of adding each stablecoin as a new dynamic field, what if we initialized a new Bag as a df and just added/removed from this bag? We can't change the registry struct, but this would standardize adding a stablecoin with adding a pool key
There was a problem hiding this comment.
Currently it's only one dynamic field stablecoinkey with the value as a vecset. Since there's no balance needed here like the balance manager, I think vecset will be better? Another idea is changing value into bag, and we can potentially resolve our vSUI/SUI stable problem (each asset added can correspond to a "base asset" like usdc or sui)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.