stake / unstake as account, remove all ctx.sender() #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonylee08
reviewed
Apr 29, 2024
| proposal_id: u64, | ||
| ctx: &mut TxContext, | ||
| ) { | ||
| state.vote(pool, proposal_id, ctx); | ||
| account.validate_proof(proof); | ||
| state.vote(pool, account, proof, proposal_id, ctx); |
There was a problem hiding this comment.
Why is proof needed if only owner can vote, or do we plan on allowing delegation of voting power as well?
There was a problem hiding this comment.
Since account is a shared object, anyone can pass any other user's account. I am just validating that the sender is the account owner via a proof. I did notice I am doing the same validation in State level as well, which I will remove
tonylee08
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will follow up this PR with: