Add filter to list, and use that to make resolve command work.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefan-mysten is attempting to deploy a commit to the Sui Foundation team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
rvantonder
reviewed
Oct 9, 2024
Comment on lines
+1228
to
+1265
| if let Some(ref filter) = filter { | ||
| if is_name(filter) { | ||
| if &name == filter { | ||
| return Ok(CommandOutput::List(vec![App { | ||
| name: name.clone(), | ||
| package_info: vec![ | ||
| (PackageInfoNetwork::Testnet, pkg_testnet), | ||
| (PackageInfoNetwork::Mainnet, pkg_mainnet), | ||
| ], | ||
| }])); | ||
| } | ||
| } | ||
| // it is an address | ||
| else { | ||
| if let Some(ref pkg) = pkg_testnet { | ||
| if &pkg.package_address.to_string() == filter { | ||
| return Ok(CommandOutput::List(vec![App { | ||
| name: name.clone(), | ||
| package_info: vec![ | ||
| (PackageInfoNetwork::Testnet, pkg_testnet), | ||
| (PackageInfoNetwork::Mainnet, pkg_mainnet), | ||
| ], | ||
| }])); | ||
| } | ||
| } | ||
| if let Some(ref pkg) = pkg_mainnet { | ||
| if &pkg.package_address.to_string() == filter { | ||
| return Ok(CommandOutput::List(vec![App { | ||
| name: name.clone(), | ||
| package_info: vec![ | ||
| (PackageInfoNetwork::Testnet, pkg_testnet), | ||
| (PackageInfoNetwork::Mainnet, pkg_mainnet), | ||
| ], | ||
| }])); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we can reduce the nesting here, but nonblocking and I'll merge and fix up. want to get these changes in before doing a rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By name -- which is the same as
mvr resolve @mvr-tst/first-appBy address
Resolve by name
Wrong name