Migrate lockfile to add missing id when only name is defined in the deps lockfile
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mvr-cli/src/lib.rs
Outdated
Comment on lines
1272
to
1274
| if !dependencies.is_array() { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
not sure I follow this...
There was a problem hiding this comment.
When would the dependencies not be an array? Is it an issue if it's not an array? Can it be not an array?
There was a problem hiding this comment.
I am trying to avoid failing when not being sure if there are any other formats in the main lockfile that could be supported. Any other recommendation?
stefan-mysten
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.