Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a banner to display a disclaimer #76

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Add a banner to display a disclaimer #76

merged 7 commits into from
Jul 8, 2024

Conversation

nonvis
Copy link
Collaborator

@nonvis nonvis commented Jun 25, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plinko-poc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 8:01am
plinko-poc-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 8:01am

@nonvis nonvis requested review from 1NickPappas and geomel June 26, 2024 05:07
1NickPappas
1NickPappas requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@1NickPappas 1NickPappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon banner doesn't work so well on mobile devices. On small screens, it overlaps with the settings component, and on larger mobile screens, the position doesn't look quite right. Additionally, the pop-up window works great on desktops, but it takes up the full width on mobile devices. It might be better to adjust it to leave some space on the sides. The functionality works great otherwise.

@nonvis
Copy link
Collaborator Author

nonvis commented Jul 3, 2024

The icon banner doesn't work so well on mobile devices. On small screens, it overlaps with the settings component, and on larger mobile screens, the position doesn't look quite right. Additionally, the pop-up window works great on desktops, but it takes up the full width on mobile devices. It might be better to adjust it to leave some space on the sides. The functionality works great otherwise.

@1NickPappas I've updated the codes so that i button does not overlap the settings component. Can you check again?

@nonvis nonvis requested a review from 1NickPappas July 3, 2024 08:04
1NickPappas
1NickPappas approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@1NickPappas 1NickPappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nonvis nonvis merged commit 102feac into main Jul 8, 2024
5 checks passed
@nonvis nonvis deleted the SE-565-add-banner branch July 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1NickPappas 1NickPappas 1NickPappas approved these changes

@geomel geomel Awaiting requested review from geomel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonvis @1NickPappas