Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial UDP skeleton and socket bind. #52

Merged
merged 9 commits into from
Nov 28, 2023
Merged

feat: initial UDP skeleton and socket bind. #52

merged 9 commits into from
Nov 28, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Nov 27, 2023 •
edited
Loading

This adds a UDP socket and binding to an address.

Still missing:

  • Integration tests for binding to an address
  • Cleanup

Closes #11

@jpcsmith jpcsmith self-assigned this Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src 70% ➖
crates/scion/src/udp 0% ❌
crates/scion-proto/src/reliable 97% ✔
crates/scion-proto/src/path/metadata 100% ✔
crates/scion-proto/src 79% ✔
crates/scion-proto/src/packet 71% ➖
crates/scion/src/daemon 94% ✔
crates/scion-proto/src/path 84% ✔
crates/scion-proto/src/address 75% ➖
Summary 78% (645 / 829) ✔

mlegner
mlegner reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jpcsmith, this looks great. (Always nice to remove a bunch of code... 😁)

Some questions and minor comments from my side.

crates/scion-proto/src/address/socket_address.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet.rs Show resolved Hide resolved
crates/scion-proto/src/wire_encoding.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/common_header.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/reliable.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/reliable/registration.rs Show resolved Hide resolved
crates/scion-proto/src/reliable/registration.rs Outdated Show resolved Hide resolved
crates/scion/src/dispatcher.rs Outdated Show resolved Hide resolved
crates/scion/src/dispatcher.rs Outdated Show resolved Hide resolved
crates/scion/src/dispatcher.rs Show resolved Hide resolved
@jpcsmith jpcsmith mentioned this pull request Nov 28, 2023
Open
@jpcsmith jpcsmith requested a review from mlegner November 28, 2023 13:48
@jpcsmith jpcsmith marked this pull request as ready for review November 28, 2023 13:48
mlegner
mlegner approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Just 1-2 open questions and an issue with the integration test in the CI environment.

crates/scion/tests/test_dispatcher.rs Outdated Show resolved Hide resolved
crates/scion/tests/udp_sanity.rs Outdated Show resolved Hide resolved
crates/scion/src/udp/socket.rs Outdated Show resolved Hide resolved
crates/scion/src/dispatcher.rs Show resolved Hide resolved
@jpcsmith jpcsmith merged commit 535c66d into main Nov 28, 2023
11 checks passed
@jpcsmith jpcsmith deleted the feat/udp branch November 28, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement interactions with dispatcher
2 participants
@jpcsmith @mlegner