-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add move entry function for verify attestation #20870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
55e7db4
to
b723402
Compare
benr-ml
reviewed
Jan 14, 2025
sui-execution/latest/sui-move-natives/src/crypto/nitro_attestation.rs
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/crypto/nitro_attestation.move
Show resolved
Hide resolved
fe48069
to
0808288
Compare
b723402
to
dd15b47
Compare
dd15b47
to
844babe
Compare
0808288
to
391f1a4
Compare
ae78b72
to
4079db6
Compare
279ca0f
to
958992f
Compare
63ca043
to
43a42cb
Compare
43a42cb
to
b3825a7
Compare
b3825a7
to
8ec1157
Compare
benr-ml
reviewed
Feb 2, 2025
crates/sui-framework/packages/sui-framework/sources/crypto/nitro_attestation.move
Outdated
Show resolved
Hide resolved
tnowacki
reviewed
Feb 5, 2025
crates/sui-framework/packages/sui-framework/sources/crypto/nitro_attestation.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/crypto/nitro_attestation.move
Outdated
Show resolved
Hide resolved
sui-execution/latest/sui-move-natives/src/crypto/nitro_attestation.rs
Outdated
Show resolved
Hide resolved
benr-ml
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's update the snapshots.
Also, let's change to entry fun load_nitro_attestation?
ef6042f
to
d8a8952
Compare
d8a8952
to
a05af2b
Compare
a05af2b
to
291fc02
Compare
291fc02
to
1d4b755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
sui replay:
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.