Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DVX-487] sui-move tests based on shell scripts #20885

Merged
merged 26 commits into from
Jan 23, 2025

Conversation

mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Jan 14, 2025

Description

This introduces a test runner for sui-move that just runs shell scripts and snapshots the output. It also adds a handful of tests for sui-move new.

Some of the tests do not pass and are commented out with linear links.

Test plan

It is tests. I did temporarily change some things locally to ensure that the tests were actually catching some errors


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 10:03pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 10:03pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 10:03pm

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George
Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Only question I have is about the commented-out tests. Wondering if it would be better to move those tests to the PR that adds support for that? Other than that it looks ready to land to me.

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George
@mdgeorge4153 mdgeorge4153 changed the title sui-move tests based on shell scripts [DVX-487] sui-move tests based on shell scripts Jan 23, 2025
@mdgeorge4153
Copy link
Contributor Author

Wondering if it would be better to move those tests to the PR that adds support for that? Other than that it looks ready to land to me.

Done - #20960

@mdgeorge4153 mdgeorge4153 enabled auto-merge (squash) January 23, 2025 18:21

Verified

This commit was signed with the committer’s verified signature.
mdgeorge4153 Michael D. George
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env January 23, 2025 22:01 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 merged commit 791ce91 into main Jan 23, 2025
51 checks passed
@mdgeorge4153 mdgeorge4153 deleted the mdgeorge/move-tests-shell branch January 23, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants