-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DVX-487] sui-move tests based on shell scripts #20885
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Only question I have is about the commented-out tests. Wondering if it would be better to move those tests to the PR that adds support for that? Other than that it looks ready to land to me.
Done - #20960 |
Description
This introduces a test runner for
sui-move
that just runs shell scripts and snapshots the output. It also adds a handful of tests forsui-move new
.Some of the tests do not pass and are commented out with linear links.
Test plan
It is tests. I did temporarily change some things locally to ensure that the tests were actually catching some errors
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.